Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_resourceexplorer2_index: New resource #28144

Merged
merged 14 commits into from
Dec 5, 2022
Merged

r/aws_resourceexplorer2_index: New resource #28144

merged 14 commits into from
Dec 5, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Dec 2, 2022 •
edited
Loading

Description

Adds the aws_resourceexplorer2_index resource.
Requires hashicorp/terraform-plugin-framework#552, via #28119, to enable timeouts support.

Relations

Relates #27717.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccResourceExplorer2_serial' PKG=resourceexplorer2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/resourceexplorer2/... -v -count 1 -parallel 20  -run=TestAccResourceExplorer2_serial -timeout 180m
=== RUN   TestAccResourceExplorer2_serial
=== RUN   TestAccResourceExplorer2_serial/Index
=== RUN   TestAccResourceExplorer2_serial/Index/basic
=== RUN   TestAccResourceExplorer2_serial/Index/disappears
=== RUN   TestAccResourceExplorer2_serial/Index/tags
=== RUN   TestAccResourceExplorer2_serial/Index/type
--- PASS: TestAccResourceExplorer2_serial (135.08s)
    --- PASS: TestAccResourceExplorer2_serial/Index (135.08s)
        --- PASS: TestAccResourceExplorer2_serial/Index/basic (25.07s)
        --- PASS: TestAccResourceExplorer2_serial/Index/disappears (18.84s)
        --- PASS: TestAccResourceExplorer2_serial/Index/tags (51.07s)
        --- PASS: TestAccResourceExplorer2_serial/Index/type (40.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/resourceexplorer2	142.805s

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/resourceexplorer2 Issues and PRs that pertain to the resourceexplorer2 service. service/simpledb Issues and PRs that pertain to the simpledb service. service/vpc Issues and PRs that pertain to the vpc service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Dec 2, 2022
@ewbankkit ewbankkit mentioned this pull request Dec 2, 2022
Closed
2 tasks
@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Dec 2, 2022
@ewbankkit ewbankkit merged commit 4e5c0e2 into main Dec 5, 2022
@ewbankkit ewbankkit deleted the f-resource-explorer-index branch December 5, 2022 20:53
@github-actions github-actions bot added this to the v4.46.0 milestone Dec 5, 2022
github-actions bot pushed a commit that referenced this pull request Dec 5, 2022
Update CHANGELOG.md for #28144
9156112
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

This functionality has been released in v4.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jan 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/resourceexplorer2 Issues and PRs that pertain to the resourceexplorer2 service. service/simpledb Issues and PRs that pertain to the simpledb service. service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.46.0
Development

Successfully merging this pull request may close these issues.
1 participant
@ewbankkit